working with drives

Question

foreach (DiskinfoDetails item in diskList1)

{

if (item.Status.Equals("Unencrypted") || item.Status.Equals("Encryption paused") || item.Status.Equals("Encryption in-progress"))

{

continue;

}

if (result == 3)

{

SystemStateInfo systemStateInfo = SystemDataLib.GetSystemState();

systemStateInfo.SystemState = ENUMSYSTEMSTATE.ENCRYPTION_COMPLETED;

SystemDataLib.SaveSystemState(systemStateInfo);

SystemDataLib.UpdateDiskStatus("Encryption Completed");

//diskList2.Add(item);

// Refresh Grid

//DriveInformation.Clear();

var data = GetSystemInfoHelper.GetPartitons();

foreach (var diskInformation in data)

{

if (bootDrive != null && item.DriveLetter == bootDrive.Replace(":", ""))

{

item.DriveSize = diskInformation.DriveSize;

item.DiskLabel = diskInformation.DiskLabel;

item.DevicePath = diskInformation.DevicePath;

item.Status = diskInformation.Status;

item.IsWindowsDrive = diskInformation.IsWindowsDrive;

break;

}

}

}

if (result == 4)

{

SystemStateInfo systemStateInfo = SystemDataLib.GetSystemState();

systemStateInfo.SystemState = ENUMSYSTEMSTATE.DECRYPTION_INPROGRESS;

SystemDataLib.SaveSystemState(systemStateInfo);

SystemDataLib.UpdateDiskStatus("Decryption In-progress");

//diskList2.Add(item);

// Refresh Grid

//DriveInformation.Clear();

var data = GetSystemInfoHelper.GetPartitons();

foreach (var diskInformation in data)

{

if (bootDrive != null && item.DriveLetter == bootDrive.Replace(":", ""))

{

item.DriveSize = diskInformation.DriveSize;

item.DiskLabel = diskInformation.DiskLabel;

item.DevicePath = diskInformation.DevicePath;

item.Status = diskInformation.Status;

item.IsWindowsDrive = diskInformation.IsWindowsDrive;

break;

}

}

}

if (result == 1)

{

SystemStateInfo systemStateInfo = SystemDataLib.GetSystemState();

systemStateInfo.SystemState = ENUMSYSTEMSTATE.DECRYPTION_COMPLETED;

SystemDataLib.SaveSystemState(systemStateInfo);

SystemDataLib.UpdateDiskStatus("Unencrypted");

BootDriveSystemSateInfo bootDriveSystemSate = SystemDataLib.GetBootDriveSystemSate();

bootDriveSystemSate.SystemState = ENUMSYSTEMSTATE.DECRYPTION_COMPLETED;

SystemDataLib.SaveBootDriveSystemState(bootDriveSystemSate);

var data = GetSystemInfoHelper.GetPartitons();

foreach (var diskInformation in data)

{

if (bootDrive != null && item.DriveLetter == bootDrive.Replace(":", ""))

{

item.DriveSize = diskInformation.DriveSize;

item.DiskLabel = diskInformation.DiskLabel;

item.DevicePath = diskInformation.DevicePath;

item.Status = diskInformation.Status;

item.IsWindowsDrive = diskInformation.IsWindowsDrive;

break;

}

}

}

diskList2.Add(item);

}

 

 

 

can i modify above logic to any simple,bcause it tooks more time to get system drives 

Answer 1

Hi. I Refactored the whole code and which is given below,

foreach (DiskinfoDetails item in diskList1)
            {
                if (item.Status.Equals("Unencrypted") || item.Status.Equals("Encryption paused") || item.Status.Equals("Encryption in-progress"))
                {
                    continue;
                }
                SystemStateInfo systemStateInfo = SystemDataLib.GetSystemState();
                if (result == 3)
                {
                    systemStateInfo.SystemState = ENUMSYSTEMSTATE.ENCRYPTION_COMPLETED;
                    SystemDataLib.SaveSystemState(systemStateInfo);
                    SystemDataLib.UpdateDiskStatus("Encryption Completed");
                }
                if (result == 4)
                {
                    systemStateInfo.SystemState = ENUMSYSTEMSTATE.DECRYPTION_INPROGRESS;
                    SystemDataLib.SaveSystemState(systemStateInfo);
                    SystemDataLib.UpdateDiskStatus("Decryption In-progress");
                }
                if (result == 1)
                {
                    systemStateInfo.SystemState = ENUMSYSTEMSTATE.DECRYPTION_COMPLETED;
                    SystemDataLib.SaveSystemState(systemStateInfo);
                    SystemDataLib.UpdateDiskStatus("Unencrypted");
                    BootDriveSystemSateInfo bootDriveSystemSate = SystemDataLib.GetBootDriveSystemSate();
                    bootDriveSystemSate.SystemState = ENUMSYSTEMSTATE.DECRYPTION_COMPLETED;
                    SystemDataLib.SaveBootDriveSystemState(bootDriveSystemSate);
                }
                var data = GetSystemInfoHelper.GetPartitons();
                foreach (var diskInformation in data)
                {
                    if (bootDrive != null && item.DriveLetter == bootDrive.Replace(":", ""))
                    {
                        item.DriveSize = diskInformation.DriveSize;
                        item.DiskLabel = diskInformation.DiskLabel;
                        item.DevicePath = diskInformation.DevicePath;
                        item.Status = diskInformation.Status;
                        item.IsWindowsDrive = diskInformation.IsWindowsDrive;
                        break;
                    }
                }
                diskList2.Add(item);
            }

 

If it helps mark as answer.

Thanks. 

Answer 2

You have so many duplicate codes so i just removed.

SystemStateInfo systemStateInfo = SystemDataLib.GetSystemState();

The above line wrote multiple times in the if clause and which is absolutely necessary. Only One time write is enough for this code.

The foreach loop you wrote multiple times in the if clause and in place of that i wrote it after all the if clauses. 

Thanks. 

Answer 3

can u elobrate me how u approach that one please 

Answer 4

my superior tells that unnessarly written foreach loop is there try to avoid foreach loop,they tells that issue not related to threads issue, issue is related to performance issue,unnessarly calling methods duplicate statements are written you have to remove them and improve the performance .they given that hint only

Answer 5

am a beginer can u help me to learn above program overall explanation what its doing or can you help me understanding way what c# concepts involved in above progarm what synatxes is help ful to me ,help me to sort out 

Answer 6

I think your code contains many methods that used to process the commands. You can check those functions or use async await programming to do this in background thread.