What is the problem of searching Informaton in my code?

Joe Wilson

My code:

public DataTable SearchStudent_Number()
{
Connection C1 = new Connection();
return C1.ShowData("select * from Student where Student_Number like '" + this.Student_Number + "%'");
}

public DataTable SearchAverage()
{
Connection C1 = new Connection();
return C1.ShowData("select * from Student where Average like '" + this.Average + "%' ");
}

public DataTable SearchLastName()
{
Connection C1 = new Connection();
return C1.ShowData("select * from Student where LastName like '" + this.LastName + "%'");
}

public DataTable SearchField()
{
Connection C1 = new Connection();
return C1.ShowData("select * from Student where Field like '" + this.Field + "%'");
}
public DataTable SearchStudent_ID()
{
Connection C1 = new Connection();
return C1.ShowData("select * from Student where Student_ID like '" + this.Student_ID + "%'");
}
}
}

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Joe Wilson12y ago
Thank you for your answer.
Guest User12y ago
I mean rather creating search function for every column you can make it generic what I did in my code. So I'm passing column name as argument to in WHERE clause and also data to it.

SearchFunction(Average , this.Average);
Average ==> columnName
this.Average==>I assume this is class in you Model where you've value for it
OR pass like this if you know exact value
SearchFunction(Average , 20);

twitter @sumitjolly
Joe Wilson12y ago
Could you please explain your answer,
Did my answer have problem?
Guest User12y ago
This code needs refactoring, you're creating functions based on columns. However, your job can be done using single function like this:
public DataTable SearchFunction(string column, string colValue)
{
Connection C1 = new Connection();
return C1.ShowData("select * from Student where "+column +" like '" + colValue + "%'");
}

Now to call this function can be done as
SearchFunction(Average , this.Average);

twitter @sumitjolly