.txt files to excel

Question

Hi I have huge text files which I want to put together together into one .csv file. The programming approach I used is very slow. How can I do this faster? Please suggest.

Francis · Answer

string []filePaths=Directory.GetFiles(@ "C:\Users\lili\Desktop\dummydata" , "*.txt" ); string filename= string .Empty; string []partsFilename; for ( int k=0;k { filename=Path.GetFileNameWithoutExtension(filePaths[k]); partsFilename=filename.Split( '_' ).ToArray(); StringBuildersbSkippedString= new StringBuilder(); StringBuildersbUnSkippedString= new StringBuilder(); if (partsFilename[0]== "customed" ) { string []datalines=File.ReadAllLines(filePaths[k]); richTextBox2.Text= "" ; if (partsFilename[partsFilename.Length-1]== "part000" ) { string []datalines1=datalines.Skip(20).ToArray(); for ( int i=0;i { sbSkippedString=sbSkippedString.Append(datalines1[i].ToString().Replace( ";" , "," )+ "
" ); //richTextBox1.Text+=datalines1[i].ToString().Replace(";",",")+"
"; //richTextBox2.Text+=datalines1[i].ToString().Replace(";",",")+"
"; //stringtext=richTextBox2.Text; //File.WriteAllText(@"C:\Users\lili\Desktop\dummydata\saved\1.csv",text); } //Finallyputthetextintherespectivetextbox //Iguessyouwanttowritetherichtext2contenttotheCSVfile richTextBox1.Text=sbSkippedString.ToString(); richTextBox2.Text=sbSkippedString.ToString(); //writeitonfile File.WriteAllText(@ "C:\Users\lili\Desktop\dummydata\saved\1.csv" ,sbSkippedString.ToString()); } else { for ( int i=0;i { sbUnSkippedString=sbUnSkippedString.Append(datalines[i].ToString().Replace( ";" , "," )+ "
" ); //richTextBox1.Text+=datalines[i].ToString().Replace(";",",")+"
"; //richTextBox2.Text+=datalines[i].ToString().Replace(";",",")+"
"; //stringtext=richTextBox2.Text; //File.AppendAllText(@"C:\Users\lili\Desktop\dummydata\saved\1.csv",text); } //Finallyputthetextintherespectivetextbox //Iguessyouwanttowritetherichtext2contenttotheCSVfile richTextBox1.Text=sbSkippedString.ToString(); richTextBox2.Text=sbSkippedString.ToString(); //writeitonfile File.WriteAllText(@ "C:\Users\lili\Desktop\dummydata\saved\1.csv" ,sbSkippedString.ToString()); } } else {} } I guess, you want to create only one CSV file at the end. As per your old code, you create the file each and every time that will kill the performance. I have optimized the code asabove. try it and let me know.

Lili R · Answer

I guess I need to learn more of code optimization. :)

Lili R · Answer

Hey, this code has solved my problem to great extent. The program has become much faster. Thank u. You are awesome!

Lili R · Answer

Hey Francis Here is a code snippet, please have a look: string[] filePaths = Directory.GetFiles(@"C:\Users\lili\Desktop\dummy data", "*.txt"); for (int k = 0; k { filename = Path.GetFileNameWithoutExtension(filePaths[k]); partsFilename = filename.Split('_').ToArray(); if (partsFilename[0] == "customed") { string[] datalines = File.ReadAllLines(filePaths[k]); richTextBox2.Text = ""; if (partsFilename[partsFilename.Length - 1] == "part000") { string[] datalines1 = datalines.Skip(20).ToArray(); for (int i = 0; i { richTextBox1.Text += datalines1[i].ToString().Replace(";", ",") + "
"; richTextBox2.Text += datalines1[i].ToString().Replace(";", ",") + "
"; string text = richTextBox2.Text; File.WriteAllText(@"C:\Users\lili\Desktop\dummy data\saved\1.csv", text); } } else { for (int i = 0; i { richTextBox1.Text += datalines[i].ToString().Replace(";", ",") + "
"; richTextBox2.Text += datalines[i].ToString().Replace(";", ",") + "
"; string text = richTextBox2.Text; File.AppendAllText(@"C:\Users\lili\Desktop\dummy data\saved\1.csv", text); } } } else { } }

Francis · Answer

You should consider to "re-structure" or "optimize" your code. Say for example, use for..each loop instead of for loop, incase you loop thru the collection object. This kind of "optimization" may improve the performance. If you want a more "good" solution, try to share your code. Without see your code we can't point the exact issue.

.txt files to excel

Answers (5)