test 2 equal poker hands for highest card to determine winni

lee croydon

Hi all,

i am trying to find a way of testing 2 equal poker hands (for example: two hands with two pairs) to determine which one wins according to the highest ranked card.

i have already tested the hands to determine there rank (for example: three of a kind, two pair etc..)

the code i have so far for determining the best hand is as follows.

if (winningHand.Length <= 0)

{

winningHand = myHand;

bestHand = hand;

handRef++;

}

else if (allHandTypes[handRef] < allHandTypes[handRef - 1])

{

winningHand = myHand;

bestHand = hand;

handRef++;

}

else if (allHandTypes[handRef] == allHandTypes[handRef - 1])

{

}

which works well up until there are 2 hands of the same rank as explained above.

what i am trying to do is compare the hand in "bestHand" to the hand in "hand" if and when we get to the last "else if" statement, then if the hand in "hand" is better than the hand in "bestHnad" then replace "bestHand" with the hand in "hand" and add "myHand" to "winningHand" any help on this would be massively appreciated or just a point in the right direction.

Thank you in advance Lee.

10 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes11y ago
Accepted answer
OK, I've done something now.

Added or altered code has been highlighted.

public enum Suit { Clubs, Diamonds, Hearts, Spades }

public enum CardNumber { Ace, King, Queen, Jack, Ten, Nine, Eight, Seven, Six, Five, Four, Three, Two }

public struct Ranking
{
public readonly int Primary; // low numbers best
public readonly int Secondary; // high numbers best

public Ranking(int primary, int secondary)
{
Primary = primary;
Secondary = secondary;
}
}

public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
}
private void Table_Click(object sender, EventArgs e)
{

}

static string[] name1 = { "Ace", "King", "Queen", "Jack", "Ten", "Nine", "Eight", "Seven", "Six", "Five", "Four", "Three", "Two" };

static string[] name2 = { "Aces", "Kings", "Queens", "Jacks", "Tens", "Nines", "Eights", "Sevens", "Sixs", "Fives", "Fours", "Threes", "Twos" };

static string[] suitsNames = { "Clubs", "Diamonds", "Hearts", "Spades" };

private void dealBtn_Click(object sender, EventArgs e)
{
Card card = new Card();
List deckOfCards = new List();
card.Deck(deckOfCards);

List allCards = new List();
List playerCards = new List();

string appPath = Path.GetDirectoryName(Application.ExecutablePath);

string[] parts = appPath.Split('\\');

string fileName = parts[0] + "\\" + parts[1] + "\\" + parts[2] + "\\" + parts[3] + "\\" + parts[4] + "\\" + parts[5] + "\\cardImages\\";

int playerValue = (int)numberOfPlayers.Value * 2;

var playersHand = deckOfCards.Take(playerValue);

string[,] ph = new string[(int)numberOfPlayers.Value, 2];

int p = 0;
int h = 0;
foreach (Card c in playersHand)
{
ph[p, h] = c.number.ToString() + c.suit.ToString() + ".png";
if (h == 1)
{
p++;
h = 0;
}
else
{
h++;
}
playerCards.Add(c);
}
Image[] phi = new Image[playerValue];
int i = 0;
foreach (string image in ph)
{
phi[i] = (Image.FromFile(fileName + image));
i++;
}

switch ((int)numberOfPlayers.Value)
{
case 2:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerOneCard2.Image = phi[2];
playerTwoCard2.Image = phi[3];
break;
case 3:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerThreeCard1.Image = phi[2];
playerOneCard2.Image = phi[3];
playerTwoCard2.Image = phi[4];
playerThreeCard2.Image = phi[5];
break;
case 4:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerThreeCard1.Image = phi[2];
playerFourCard1.Image = phi[3];
playerOneCard2.Image = phi[4];
playerTwoCard2.Image = phi[5];
playerThreeCard2.Image = phi[6];
playerFourCard2.Image = phi[7];
break;
case 5:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerThreeCard1.Image = phi[2];
playerFourCard1.Image = phi[3];
playerFiveCard1.Image = phi[4];
playerOneCard2.Image = phi[5];
playerTwoCard2.Image = phi[6];
playerThreeCard2.Image = phi[7];
playerFourCard2.Image = phi[8];
playerFiveCard2.Image = phi[9];
break;
case 6:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerThreeCard1.Image = phi[2];
playerFourCard1.Image = phi[3];
playerFiveCard1.Image = phi[4];
playerSixCard1.Image = phi[5];
playerOneCard2.Image = phi[6];
playerTwoCard2.Image = phi[7];
playerThreeCard2.Image = phi[8];
playerFourCard2.Image = phi[9];
playerFiveCard2.Image = phi[10];
playerSixCard2.Image = phi[11];
break;
case 7:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerThreeCard1.Image = phi[2];
playerFourCard1.Image = phi[3];
playerFiveCard1.Image = phi[4];
playerSixCard1.Image = phi[5];
playerSevenCard1.Image = phi[6];
playerOneCard2.Image = phi[7];
playerTwoCard2.Image = phi[8];
playerThreeCard2.Image = phi[9];
playerFourCard2.Image = phi[10];
playerFiveCard2.Image = phi[11];
playerSixCard2.Image = phi[12];
playerSevenCard2.Image = phi[13];
break;
case 8:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerThreeCard1.Image = phi[2];
playerFourCard1.Image = phi[3];
playerFiveCard1.Image = phi[4];
playerSixCard1.Image = phi[5];
playerSevenCard1.Image = phi[6];
playerEightCard1.Image = phi[7];
playerOneCard2.Image = phi[8];
playerTwoCard2.Image = phi[9];
playerThreeCard2.Image = phi[10];
playerFourCard2.Image = phi[11];
playerFiveCard2.Image = phi[12];
playerSixCard2.Image = phi[13];
playerSevenCard2.Image = phi[14];
playerEightCard2.Image = phi[15];
break;
default:
MessageBox.Show("Invalid number of players, minimum of 2 and a maximum of 8 players aloud");
break;
}

deckOfCards.RemoveRange(0, playerValue);

var burnCard = deckOfCards.Take(1);

foreach (Card c in burnCard)
{
deckOfCards.Remove(c);
}

var flop = deckOfCards.Take(3);
string[] fp = new string[3];
i = 0;
foreach (Card c in flop)
{
fp[i] = c.number.ToString() + c.suit.ToString() + ".png";
i++;
allCards.Add(c);
}
Image[] fpi = new Image[3];
i = 0;
foreach (string image in fp)
{
fpi[i] = (Image.FromFile(fileName + image));
i++;
}
flop1.Image = fpi[0];
flop2.Image = fpi[1];
flop3.Image = fpi[2];

deckOfCards.RemoveRange(0, 3);

burnCard = deckOfCards.Take(1);

foreach (Card c in burnCard)
{
c.isUsed = true;
}

var turn = deckOfCards.Take(1);
string[] tn = new string[1];
i = 0;
foreach (Card c in turn)
{
tn[i] = c.number.ToString() + c.suit.ToString() + ".png";
deckOfCards.Remove(c);
allCards.Add(c);
}
Image tni;
foreach (string image in tn)
{
tni = (Image.FromFile(fileName + image));

turnCard.Image = tni;
}

burnCard = deckOfCards.Take(1);
card.isUsed = deckOfCards.Contains(card);

foreach (Card c in burnCard)
{
deckOfCards.Remove(c);
}

var river = deckOfCards.Take(1);
string[] rir = new string[1];
i = 0;
foreach (Card c in river)
{
rir[i] = c.number.ToString() + c.suit.ToString() + ".png";
deckOfCards.Remove(c);
allCards.Add(c);
}
Image riri;
foreach (string image in rir)
{
riri = (Image.FromFile(fileName + image));

riverCard.Image = riri;
}
switch ((int)numberOfPlayers.Value)
{
case 2:
Card[] player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(2));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

Card[] player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(3));
player2 = allCards.ToArray();

card.Evaluator(player2);
MessageBox.Show("Player wins with " + card.winningHand);
card.winningHand.Remove(1);
Card.handRef = 0;
Card.allHandTypes.Clear();
break;
case 3:
player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(3));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(4));
player2 = allCards.ToArray();

card.Evaluator(player2);
allCards.RemoveRange(5, 2);

Card[] player3 = new Card[7];
allCards.Add(playerCards.ElementAt(2));
allCards.Add(playerCards.ElementAt(5));
player3 = allCards.ToArray();

card.Evaluator(player3);
MessageBox.Show("Player wins with " + card.winningHand);
break;
case 4:
player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(4));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(5));
player2 = allCards.ToArray();

card.Evaluator(player2);
allCards.RemoveRange(5, 2);

player3 = new Card[7];
allCards.Add(playerCards.ElementAt(2));
allCards.Add(playerCards.ElementAt(6));
player3 = allCards.ToArray();

card.Evaluator(player3);
allCards.RemoveRange(5, 2);

Card[] player4 = new Card[7];
allCards.Add(playerCards.ElementAt(3));
allCards.Add(playerCards.ElementAt(7));
player4 = allCards.ToArray();

card.Evaluator(player4);
MessageBox.Show("Player wins with " + card.winningHand);
break;
case 5:
player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(5));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(6));
player2 = allCards.ToArray();

card.Evaluator(player2);
allCards.RemoveRange(5, 2);

player3 = new Card[7];
allCards.Add(playerCards.ElementAt(2));
allCards.Add(playerCards.ElementAt(7));
player3 = allCards.ToArray();

card.Evaluator(player3);
allCards.RemoveRange(5, 2);

player4 = new Card[7];
allCards.Add(playerCards.ElementAt(3));
allCards.Add(playerCards.ElementAt(8));
player4 = allCards.ToArray();

card.Evaluator(player4);
allCards.RemoveRange(5, 2);

Card[] player5 = new Card[7];
allCards.Add(playerCards.ElementAt(4));
allCards.Add(playerCards.ElementAt(9));
player5 = allCards.ToArray();

card.Evaluator(player5);
MessageBox.Show("Player wins with " + card.winningHand);
break;
case 6:
player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(6));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(7));
player2 = allCards.ToArray();

card.Evaluator(player2);
allCards.RemoveRange(5, 2);

player3 = new Card[7];
allCards.Add(playerCards.ElementAt(2));
allCards.Add(playerCards.ElementAt(8));
player3 = allCards.ToArray();

card.Evaluator(player3);
allCards.RemoveRange(5, 2);

player4 = new Card[7];
allCards.Add(playerCards.ElementAt(3));
allCards.Add(playerCards.ElementAt(9));
player4 = allCards.ToArray();

card.Evaluator(player4);
allCards.RemoveRange(5, 2);

player5 = new Card[7];
allCards.Add(playerCards.ElementAt(4));
allCards.Add(playerCards.ElementAt(10));
player5 = allCards.ToArray();

card.Evaluator(player5);
allCards.RemoveRange(5, 2);

Card[] player6 = new Card[7];
allCards.Add(playerCards.ElementAt(5));
allCards.Add(playerCards.ElementAt(11));
player6 = allCards.ToArray();

card.Evaluator(player6);
MessageBox.Show("Player wins with " + card.winningHand);
break;
case 7:
player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(7));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(8));
player2 = allCards.ToArray();

card.Evaluator(player2);
allCards.RemoveRange(5, 2);

player3 = new Card[7];
allCards.Add(playerCards.ElementAt(2));
allCards.Add(playerCards.ElementAt(9));
player3 = allCards.ToArray();

card.Evaluator(player3);
allCards.RemoveRange(5, 2);

player4 = new Card[7];
allCards.Add(playerCards.ElementAt(3));
allCards.Add(playerCards.ElementAt(10));
player4 = allCards.ToArray();

card.Evaluator(player4);
allCards.RemoveRange(5, 2);

player5 = new Card[7];
allCards.Add(playerCards.ElementAt(4));
allCards.Add(playerCards.ElementAt(11));
player5 = allCards.ToArray();

card.Evaluator(player5);
allCards.RemoveRange(5, 2);

player6 = new Card[7];
allCards.Add(playerCards.ElementAt(5));
allCards.Add(playerCards.ElementAt(12));
player6 = allCards.ToArray();

card.Evaluator(player6);
allCards.RemoveRange(5, 2);

Card[] player7 = new Card[7];
allCards.Add(playerCards.ElementAt(6));
allCards.Add(playerCards.ElementAt(13));
player7 = allCards.ToArray();

card.Evaluator(player7);
MessageBox.Show("Player wins with " + card.winningHand);
break;
case 8:
player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(8));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(9));
player2 = allCards.ToArray();

card.Evaluator(player2);
allCards.RemoveRange(5, 2);

player3 = new Card[7];
allCards.Add(playerCards.ElementAt(2));
allCards.Add(playerCards.ElementAt(10));
player3 = allCards.ToArray();

card.Evaluator(player3);
allCards.RemoveRange(5, 2);

player4 = new Card[7];
allCards.Add(playerCards.ElementAt(3));
allCards.Add(playerCards.ElementAt(11));
player4 = allCards.ToArray();

card.Evaluator(player4);
allCards.RemoveRange(5, 2);

player5 = new Card[7];
allCards.Add(playerCards.ElementAt(4));
allCards.Add(playerCards.ElementAt(12));
player5 = allCards.ToArray();

card.Evaluator(player5);
allCards.RemoveRange(5, 2);

player6 = new Card[7];
allCards.Add(playerCards.ElementAt(5));
allCards.Add(playerCards.ElementAt(13));
player6 = allCards.ToArray();

card.Evaluator(player6);
allCards.RemoveRange(5, 2);

player7 = new Card[7];
allCards.Add(playerCards.ElementAt(6));
allCards.Add(playerCards.ElementAt(14));
player7 = allCards.ToArray();

card.Evaluator(player7);
allCards.RemoveRange(5, 2);

Card[] player8 = new Card[7];
allCards.Add(playerCards.ElementAt(7));
allCards.Add(playerCards.ElementAt(15));
player8 = allCards.ToArray();

card.Evaluator(player8);
MessageBox.Show("Player wins with " + card.winningHand);
break;
}
}

public class Card
{
private static Random rand = new Random();

public Suit suit;
public CardNumber number;
public bool isUsed = false;
public string winningHand = "";
public static int handRef = 0;
public static List allHandTypes = new List(); //*** now List rather than List
public static Card[] bestHand = new Card[7];

//produce random suit and number
public Card()
{
suit = (Suit)rand.Next(0, 4);
number = (CardNumber)rand.Next(0, 13);
}
//Create a shuffled Deck of cards
public void Deck(List c)
{
do
{
Card card = new Card();
bool exists = c.Exists(x => x.suit == card.suit && x.number == card.number);
if (exists == false)
{
c.Add(card);
}
}
while (c.Count < 52);
}
public void Evaluator(Card[] hand)
{
//*** denotes new or amended lines
// sort by multiples
var groupings = from aCard in hand
group aCard by aCard.number into g
orderby g.Count() descending, g.Key
select g;

int handType = -1;
int handType2 = -1; //***
string myHand = null;

//check for card multiples

int count1 = groupings.First().Count();
int count2 = groupings.ElementAt(1).Count();
int value1 = (int)groupings.First().Key;
int value2 = (int)groupings.ElementAt(1).Key;
int value3 = -1; //***
if(groupings.Count() >= 3) value3 = (int)groupings.ElementAt(2).Key; //***
int value4 = -1; //***
if(groupings.Count() >= 4) value4 = (int)groupings.ElementAt(3).Key; //***
int value5 = -1; //***
if(groupings.Count() >= 5) value5 = (int)groupings.ElementAt(4).Key; //***

if (count1 == 4)
{
handType = 1;
handType2 = 14 - value1; //***
allHandTypes.Add(new Ranking(handType, handType2)); //***
myHand = "Four " + name2[value1];
}
else if (count1 == 3 && count2 >= 2)
{
handType = 2;
handType2 = (14 - value1) * 14 + (14 - value2); //***
allHandTypes.Add(new Ranking(handType, handType2)); //***
myHand = "Full House- " + name2[value1] + " and " + name2[value2];
}
else if (count1 == 3)
{
handType = 5;
handType2 = 14 - value1; //***
allHandTypes.Add(new Ranking(handType, handType2)); //***
myHand = "Three " + name2[value1];
}
else if (count1 == 2 && count2 == 2)
{
handType = 6;
handType2 = (14 - value1) * (14 - value2) + (14 - value3); //***
allHandTypes.Add(new Ranking(handType, handType2)); //***
myHand = "Two Pairs- " + name2[value1] + " and " + name2[value2];
}
else if (count1 == 2)
{
handType = 7;
handType2 = (14 - value1) * 2744 + (14 - value2) * (14 - value3) * (14 - value4); //***
allHandTypes.Add(new Ranking(handType, handType2)); //***
myHand = "Pair of " + name2[value1];
}
else
{
handType = 8;
handType2 = (14 - value1) * (14 - value2) * (14 - value3) * (14 -value4) * (14 - value5); //***
allHandTypes.Add(new Ranking(handType, handType2)); //***
myHand = name1[value1] + " High";
}

hand = (from aCard in hand orderby aCard.number select aCard).ToArray();

Card[] distinctCards = hand.Distinct(new CardValueComparer()).ToArray();

bool straight = false;

if (distinctCards.Length >= 5)
{
for (int i = 0; i < distinctCards.Length - 4; i++)
{
if (distinctCards[i].number == distinctCards[i + 4].number - 4)
{
if (handType > 4)
{
allHandTypes.RemoveAt(handRef);
myHand = name1[(int)distinctCards[i].number] + " high straight"; //*** straight typo
handType = 4;
handType2 = 14 - (int)distinctCards[i].number; //***
allHandTypes.Add(new Ranking(handType, handType2)); //***
}
straight = true;
break;
}
}
}
//sort by suit
var suitGrouping = from aCard in hand
group aCard by aCard.suit
into s
orderby s.Count() descending
select s;

//now check for flush
int count = suitGrouping.First().Count();

if (count >= 5)
{
int index = (int)suitGrouping.First().First().number;
int suit = (int)suitGrouping.First().Key;

if (handType > 3)
{
allHandTypes.RemoveAt(handRef);
handType = 3;
handType2 = 1; //***
for(int i = 0; i <= 4; i++) handType2 *= 14 - (int)suitGrouping.First().ElementAt(i).number; //***
allHandTypes.Add(new Ranking(handType, handType2)); //***
myHand = name1[index] + "-high flush in " + suitsNames[suit];
}
if (straight)
{
//now check for straight flush //*** straight typo
Card[] flushCards = (from aCard in suitGrouping.First() orderby aCard.number select aCard).ToArray();

for (int i = 0; i < count - 4; i++)
{
if (flushCards[i].number == flushCards[i + 4].number - 4)
{
bool straightFlush = true;
int flushSuit = (int)flushCards[i].suit;

for (int j = i + 1; j < i + 5; j++)
{
if (flushSuit != (int)flushCards[i].suit)
{
straightFlush = false;
break;
}
}
if (straightFlush)
{
allHandTypes.RemoveAt(handRef);
handType = 0;
handType2 = 14 - (int)flushCards[i].number; //***
allHandTypes.Add(new Ranking(handType, handType2)); //***
myHand = name1[(int)flushCards[i].number] + "-High straight flush in " + suitsNames[(int)flushCards[i].suit];
break;
}
}
}
}
}


if (winningHand.Length <= 0)
{
winningHand = myHand;
bestHand = hand;
handRef++;
}
else if (allHandTypes[handRef].Primary < allHandTypes[handRef - 1].Primary) //***
{
winningHand = myHand;
bestHand = hand;
handRef++;
}
else if (allHandTypes[handRef].Primary == allHandTypes[handRef - 1].Primary) //***
{
if(allHandTypes[handRef].Secondary > allHandTypes[handRef - 1].Secondary) //*** (note '>' rather than '<')
{
winningHand = myHand; //***
bestHand = hand; //***
handRef++; //***
}
}
}
class CardValueComparer : IEqualityComparer
{
public bool Equals(Card c1, Card c2)
{
return c1.number == c2.number;
}
public int GetHashCode(Card c)
{
return c.number.GetHashCode();
}
}
public class PlayerOptions
{
//TODO
private double pot;
private double stake;
private double bankRoll = 1500;
public double bigBlind = 50;
public double smallBlind = 25;
public bool noBet;

public void Call()
{

if (noBet == false)
{
bankRoll = bankRoll - bigBlind;
noBet = true;
pot = bigBlind + bigBlind + smallBlind;
stake = bigBlind;
}
else if (bankRoll == bankRoll - smallBlind)
{
double temp = stake - smallBlind;
bankRoll -= temp;
}
else
{
bankRoll -= stake;
pot += stake;
}
}
public void Raise()
{
}
public void Fold()
{
}
}
}
}
}
lee croydon11y ago
Vulpes you are a genius, thank you so much. if i can think up and write code like you one day ill be a very happy man :)
Vithal Wadje11y ago
nice explanation
Vulpes11y ago
OK, I think I should be able to change that to add the secondary ranking.

As I've got some other stuff to do right now and it needs some careful thought, I'll try and get back later today.
lee croydon11y ago
Thank you Vulpes,

as of now the entire code is below ignore the betting methods at the bottom they are a work in progress : )

public enum Suit { Clubs, Diamonds, Hearts, Spades }

public enum CardNumber { Ace, King, Queen, Jack, Ten, Nine, Eight, Seven, Six, Five, Four, Three, Two }

public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
}
private void Table_Click(object sender, EventArgs e)
{

}

static string[] name1 = { "Ace", "King", "Queen", "Jack", "Ten", "Nine", "Eight", "Seven", "Six", "Five", "Four", "Three", "Two" };

static string[] name2 = { "Aces", "Kings", "Queens", "Jacks", "Tens", "Nines", "Eights", "Sevens", "Sixs", "Fives", "Fours", "Threes", "Twos" };

static string[] suitsNames = { "Clubs", "Diamonds", "Hearts", "Spades" };

private void dealBtn_Click(object sender, EventArgs e)
{
Card card = new Card();
List deckOfCards = new List();
card.Deck(deckOfCards);

List allCards = new List();
List playerCards = new List();

string appPath = Path.GetDirectoryName(Application.ExecutablePath);

string[] parts = appPath.Split('\\');

string fileName = parts[0] + "\\" + parts[1] + "\\" + parts[2] + "\\" + parts[3] + "\\" + parts[4] + "\\" + parts[5] + "\\cardImages\\";

int playerValue = (int)numberOfPlayers.Value * 2;

var playersHand = deckOfCards.Take(playerValue);

string[,] ph = new string[(int)numberOfPlayers.Value, 2];

int p = 0;
int h = 0;
foreach (Card c in playersHand)
{
ph[p, h] = c.number.ToString() + c.suit.ToString() + ".png";
if (h == 1)
{
p++;
h = 0;
}
else
{
h++;
}
playerCards.Add(c);
}
Image[] phi = new Image[playerValue];
int i = 0;
foreach (string image in ph)
{
phi[i] = (Image.FromFile(fileName + image));
i++;
}

switch ((int)numberOfPlayers.Value)
{
case 2:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerOneCard2.Image = phi[2];
playerTwoCard2.Image = phi[3];
break;
case 3:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerThreeCard1.Image = phi[2];
playerOneCard2.Image = phi[3];
playerTwoCard2.Image = phi[4];
playerThreeCard2.Image = phi[5];
break;
case 4:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerThreeCard1.Image = phi[2];
playerFourCard1.Image = phi[3];
playerOneCard2.Image = phi[4];
playerTwoCard2.Image = phi[5];
playerThreeCard2.Image = phi[6];
playerFourCard2.Image = phi[7];
break;
case 5:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerThreeCard1.Image = phi[2];
playerFourCard1.Image = phi[3];
playerFiveCard1.Image = phi[4];
playerOneCard2.Image = phi[5];
playerTwoCard2.Image = phi[6];
playerThreeCard2.Image = phi[7];
playerFourCard2.Image = phi[8];
playerFiveCard2.Image = phi[9];
break;
case 6:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerThreeCard1.Image = phi[2];
playerFourCard1.Image = phi[3];
playerFiveCard1.Image = phi[4];
playerSixCard1.Image = phi[5];
playerOneCard2.Image = phi[6];
playerTwoCard2.Image = phi[7];
playerThreeCard2.Image = phi[8];
playerFourCard2.Image = phi[9];
playerFiveCard2.Image = phi[10];
playerSixCard2.Image = phi[11];
break;
case 7:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerThreeCard1.Image = phi[2];
playerFourCard1.Image = phi[3];
playerFiveCard1.Image = phi[4];
playerSixCard1.Image = phi[5];
playerSevenCard1.Image = phi[6];
playerOneCard2.Image = phi[7];
playerTwoCard2.Image = phi[8];
playerThreeCard2.Image = phi[9];
playerFourCard2.Image = phi[10];
playerFiveCard2.Image = phi[11];
playerSixCard2.Image = phi[12];
playerSevenCard2.Image = phi[13];
break;
case 8:
playerOneCard1.Image = phi[0];
playerTwoCard1.Image = phi[1];
playerThreeCard1.Image = phi[2];
playerFourCard1.Image = phi[3];
playerFiveCard1.Image = phi[4];
playerSixCard1.Image = phi[5];
playerSevenCard1.Image = phi[6];
playerEightCard1.Image = phi[7];
playerOneCard2.Image = phi[8];
playerTwoCard2.Image = phi[9];
playerThreeCard2.Image = phi[10];
playerFourCard2.Image = phi[11];
playerFiveCard2.Image = phi[12];
playerSixCard2.Image = phi[13];
playerSevenCard2.Image = phi[14];
playerEightCard2.Image = phi[15];
break;
default:
MessageBox.Show("Invalid number of players, minimum of 2 and a maximum of 8 players aloud");
break;
}

deckOfCards.RemoveRange(0, playerValue);

var burnCard = deckOfCards.Take(1);

foreach (Card c in burnCard)
{
deckOfCards.Remove(c);
}

var flop = deckOfCards.Take(3);
string[] fp = new string[3];
i = 0;
foreach (Card c in flop)
{
fp[i] = c.number.ToString() + c.suit.ToString() + ".png";
i++;
allCards.Add(c);
}
Image[] fpi = new Image[3];
i = 0;
foreach (string image in fp)
{
fpi[i] = (Image.FromFile(fileName + image));
i++;
}
flop1.Image = fpi[0];
flop2.Image = fpi[1];
flop3.Image = fpi[2];

deckOfCards.RemoveRange(0, 3);

burnCard = deckOfCards.Take(1);

foreach (Card c in burnCard)
{
c.isUsed = true;
}

var turn = deckOfCards.Take(1);
string[] tn = new string[1];
i = 0;
foreach (Card c in turn)
{
tn[i] = c.number.ToString() + c.suit.ToString() + ".png";
deckOfCards.Remove(c);
allCards.Add(c);
}
Image tni;
foreach (string image in tn)
{
tni = (Image.FromFile(fileName + image));

turnCard.Image = tni;
}

burnCard = deckOfCards.Take(1);
card.isUsed = deckOfCards.Contains(card);

foreach (Card c in burnCard)
{
deckOfCards.Remove(c);
}

var river = deckOfCards.Take(1);
string[] rir = new string[1];
i = 0;
foreach (Card c in river)
{
rir[i] = c.number.ToString() + c.suit.ToString() + ".png";
deckOfCards.Remove(c);
allCards.Add(c);
}
Image riri;
foreach (string image in rir)
{
riri = (Image.FromFile(fileName + image));

riverCard.Image = riri;
}
switch ((int)numberOfPlayers.Value)
{
case 2:
Card[] player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(2));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

Card[] player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(3));
player2 = allCards.ToArray();

card.Evaluator(player2);
MessageBox.Show("Player wins with " + card.winningHand);
card.winningHand.Remove(1);
Card.handRef = 0;
Card.allHandTypes.Clear();
break;
case 3:
player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(3));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(4));
player2 = allCards.ToArray();

card.Evaluator(player2);
allCards.RemoveRange(5, 2);

Card[] player3 = new Card[7];
allCards.Add(playerCards.ElementAt(2));
allCards.Add(playerCards.ElementAt(5));
player3 = allCards.ToArray();

card.Evaluator(player3);
MessageBox.Show("Player wins with " + card.winningHand);
break;
case 4:
player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(4));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(5));
player2 = allCards.ToArray();

card.Evaluator(player2);
allCards.RemoveRange(5, 2);

player3 = new Card[7];
allCards.Add(playerCards.ElementAt(2));
allCards.Add(playerCards.ElementAt(6));
player3 = allCards.ToArray();

card.Evaluator(player3);
allCards.RemoveRange(5, 2);

Card[] player4 = new Card[7];
allCards.Add(playerCards.ElementAt(3));
allCards.Add(playerCards.ElementAt(7));
player4 = allCards.ToArray();

card.Evaluator(player4);
MessageBox.Show("Player wins with " + card.winningHand);
break;
case 5:
player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(5));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(6));
player2 = allCards.ToArray();

card.Evaluator(player2);
allCards.RemoveRange(5, 2);

player3 = new Card[7];
allCards.Add(playerCards.ElementAt(2));
allCards.Add(playerCards.ElementAt(7));
player3 = allCards.ToArray();

card.Evaluator(player3);
allCards.RemoveRange(5, 2);

player4 = new Card[7];
allCards.Add(playerCards.ElementAt(3));
allCards.Add(playerCards.ElementAt(8));
player4 = allCards.ToArray();

card.Evaluator(player4);
allCards.RemoveRange(5, 2);

Card[] player5 = new Card[7];
allCards.Add(playerCards.ElementAt(4));
allCards.Add(playerCards.ElementAt(9));
player5 = allCards.ToArray();

card.Evaluator(player5);
MessageBox.Show("Player wins with " + card.winningHand);
break;
case 6:
player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(6));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(7));
player2 = allCards.ToArray();

card.Evaluator(player2);
allCards.RemoveRange(5, 2);

player3 = new Card[7];
allCards.Add(playerCards.ElementAt(2));
allCards.Add(playerCards.ElementAt(8));
player3 = allCards.ToArray();

card.Evaluator(player3);
allCards.RemoveRange(5, 2);

player4 = new Card[7];
allCards.Add(playerCards.ElementAt(3));
allCards.Add(playerCards.ElementAt(9));
player4 = allCards.ToArray();

card.Evaluator(player4);
allCards.RemoveRange(5, 2);

player5 = new Card[7];
allCards.Add(playerCards.ElementAt(4));
allCards.Add(playerCards.ElementAt(10));
player5 = allCards.ToArray();

card.Evaluator(player5);
allCards.RemoveRange(5, 2);

Card[] player6 = new Card[7];
allCards.Add(playerCards.ElementAt(5));
allCards.Add(playerCards.ElementAt(11));
player6 = allCards.ToArray();

card.Evaluator(player6);
MessageBox.Show("Player wins with " + card.winningHand);
break;
case 7:
player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(7));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(8));
player2 = allCards.ToArray();

card.Evaluator(player2);
allCards.RemoveRange(5, 2);

player3 = new Card[7];
allCards.Add(playerCards.ElementAt(2));
allCards.Add(playerCards.ElementAt(9));
player3 = allCards.ToArray();

card.Evaluator(player3);
allCards.RemoveRange(5, 2);

player4 = new Card[7];
allCards.Add(playerCards.ElementAt(3));
allCards.Add(playerCards.ElementAt(10));
player4 = allCards.ToArray();

card.Evaluator(player4);
allCards.RemoveRange(5, 2);

player5 = new Card[7];
allCards.Add(playerCards.ElementAt(4));
allCards.Add(playerCards.ElementAt(11));
player5 = allCards.ToArray();

card.Evaluator(player5);
allCards.RemoveRange(5, 2);

player6 = new Card[7];
allCards.Add(playerCards.ElementAt(5));
allCards.Add(playerCards.ElementAt(12));
player6 = allCards.ToArray();

card.Evaluator(player6);
allCards.RemoveRange(5, 2);

Card[] player7 = new Card[7];
allCards.Add(playerCards.ElementAt(6));
allCards.Add(playerCards.ElementAt(13));
player7 = allCards.ToArray();

card.Evaluator(player7);
MessageBox.Show("Player wins with " + card.winningHand);
break;
case 8:
player1 = new Card[7];
allCards.Add(playerCards.ElementAt(0));
allCards.Add(playerCards.ElementAt(8));
player1 = allCards.ToArray();

card.Evaluator(player1);
allCards.RemoveRange(5, 2);

player2 = new Card[7];
allCards.Add(playerCards.ElementAt(1));
allCards.Add(playerCards.ElementAt(9));
player2 = allCards.ToArray();

card.Evaluator(player2);
allCards.RemoveRange(5, 2);

player3 = new Card[7];
allCards.Add(playerCards.ElementAt(2));
allCards.Add(playerCards.ElementAt(10));
player3 = allCards.ToArray();

card.Evaluator(player3);
allCards.RemoveRange(5, 2);

player4 = new Card[7];
allCards.Add(playerCards.ElementAt(3));
allCards.Add(playerCards.ElementAt(11));
player4 = allCards.ToArray();

card.Evaluator(player4);
allCards.RemoveRange(5, 2);

player5 = new Card[7];
allCards.Add(playerCards.ElementAt(4));
allCards.Add(playerCards.ElementAt(12));
player5 = allCards.ToArray();

card.Evaluator(player5);
allCards.RemoveRange(5, 2);

player6 = new Card[7];
allCards.Add(playerCards.ElementAt(5));
allCards.Add(playerCards.ElementAt(13));
player6 = allCards.ToArray();

card.Evaluator(player6);
allCards.RemoveRange(5, 2);

player7 = new Card[7];
allCards.Add(playerCards.ElementAt(6));
allCards.Add(playerCards.ElementAt(14));
player7 = allCards.ToArray();

card.Evaluator(player7);
allCards.RemoveRange(5, 2);

Card[] player8 = new Card[7];
allCards.Add(playerCards.ElementAt(7));
allCards.Add(playerCards.ElementAt(15));
player8 = allCards.ToArray();

card.Evaluator(player8);
MessageBox.Show("Player wins with " + card.winningHand);
break;
}
}

public class Card
{
private static Random rand = new Random();

public Suit suit;
public CardNumber number;
public bool isUsed = false;
public string winningHand = "";
public static int handRef = 0;
public static List allHandTypes = new List();
public static Card[] bestHand = new Card[7];

//produce random suit and number
public Card()
{
suit = (Suit)rand.Next(0, 4);
number = (CardNumber)rand.Next(0, 13);
}
//Create a shuffled Deck of cards
public void Deck(List c)
{
do
{
Card card = new Card();
bool exists = c.Exists(x => x.suit == card.suit && x.number == card.number);
if (exists == false)
{
c.Add(card);
}
}
while (c.Count < 52);
}
public void Evaluator(Card[] hand)
{
// sort by multiples
var groupings = from aCard in hand
group aCard by aCard.number into g
orderby g.Count() descending, g.Key
select g;

int handType = -1;
string myHand = null;

//check for card multiples

int count1 = groupings.First().Count();
int count2 = groupings.ElementAt(1).Count();
int value1 = (int)groupings.First().Key;
int value2 = (int)groupings.ElementAt(1).Key;

if (count1 == 4)
{
handType = 1;
allHandTypes.Add(handType);
myHand = "Four " + name2[value1];
}
else if (count1 == 3 && count2 >= 2)
{
handType = 2;
allHandTypes.Add(handType);
myHand = "Full House- " + name2[value1] + " and " + name2[value2];
}
else if (count1 == 3)
{
handType = 5;
allHandTypes.Add(handType);
myHand = "Three " + name2[value1];
}
else if (count1 == 2 && count2 == 2)
{
handType = 6;
allHandTypes.Add(handType);
myHand = "Two Pairs- " + name2[value1] + " and " + name2[value2];
}
else if (count1 == 2)
{
handType = 7;
allHandTypes.Add(handType);
myHand = "Pair of " + name2[value1];
}
else
{
handType = 8;
allHandTypes.Add(handType);
myHand = name1[value1] + " High";
}

hand = (from aCard in hand orderby aCard.number select aCard).ToArray();

Card[] distinctCards = hand.Distinct(new CardValueComparer()).ToArray();

bool straight = false;

if (distinctCards.Length >= 5)
{
for (int i = 0; i < distinctCards.Length - 4; i++)
{
if (distinctCards[i].number == distinctCards[i + 4].number - 4)
{
if (handType > 4)
{
allHandTypes.RemoveAt(handRef);
myHand = name1[(int)distinctCards[i].number] + " high striaght";
handType = 4;
allHandTypes.Add(handType);
}
straight = true;
break;
}
}
}
//sort by suit
var suitGrouping = from aCard in hand
group aCard by aCard.suit
into s
orderby s.Count() descending
select s;

//now check for flush
int count = suitGrouping.First().Count();

if (count >= 5)
{
int index = (int)suitGrouping.First().First().number;
int suit = (int)suitGrouping.First().Key;

if (handType > 3)
{
allHandTypes.RemoveAt(handRef);
handType = 3;
allHandTypes.Add(handType);
myHand = name1[index] + "-high flush in " + suitsNames[suit];
}
if (straight)
{
//now check for striaght flush
Card[] flushCards = (from aCard in suitGrouping.First() orderby aCard.number select aCard).ToArray();

for (int i = 0; i < count - 4; i++)
{
if (flushCards[i].number == flushCards[i + 4].number - 4)
{
bool straightFlush = true;
int flushSuit = (int)flushCards[i].suit;

for (int j = i + 1; j < i + 5; j++)
{
if (flushSuit != (int)flushCards[i].suit)
{
straightFlush = false;
break;
}
}
if (straightFlush)
{
allHandTypes.RemoveAt(handRef);
handType = 0;
allHandTypes.Add(handType);
myHand = name1[(int)flushCards[i].number] + "-High straight flush in " + suitsNames[(int)flushCards[i].suit];
break;
}
}
}
}
}

if (winningHand.Length <= 0)
{
winningHand = myHand;
bestHand = hand;
handRef++;
}
else if (allHandTypes[handRef] < allHandTypes[handRef - 1])
{
winningHand = myHand;
bestHand = hand;
handRef++;
}
else if (allHandTypes[handRef] == allHandTypes[handRef - 1])
{

}
}
class CardValueComparer : IEqualityComparer
{
public bool Equals(Card c1, Card c2)
{
return c1.number == c2.number;
}
public int GetHashCode(Card c)
{
return c.number.GetHashCode();
}
}
public class PlayerOptions
{
//TODO
private double pot;
private double stake;
private double bankRoll = 1500;
public double bigBlind = 50;
public double smallBlind = 25;
public bool noBet;

public void Call()
{

if (noBet == false)
{
bankRoll = bankRoll - bigBlind;
noBet = true;
pot = bigBlind + bigBlind + smallBlind;
stake = bigBlind;
}
else if (bankRoll == bankRoll - smallBlind)
{
double temp = stake - smallBlind;
bankRoll -= temp;
}
else
{
bankRoll -= stake;
pot += stake;
}
}
public void Raise()
{
}
public void Fold()
{
}
}
}
}
}
Vulpes11y ago
It will be more complicated but it's still manageable.

For example, suppose you create a struct to bind the two rankings together as I suggested above:

struct Ranking
{
public readonly int Primary;
public readonly int Secondary;

public Ranking(int primary, int secondary)
{
Primary = primary;
Secondary = secondary;
}
}

Your allHandTypes array could then be declared as an array of Ranking rather than (presunably) an array of int and the snippet you posted would change to:

if (winningHand.Length <= 0)
{
winningHand = myHand;
bestHand = hand;
handRef++;
}
else if (allHandTypes[handRef].Primary < allHandTypes[handRef - 1].Primary)
{
winningHand = myHand;
bestHand = hand;
handRef++;
}
else if (allHandTypes[handRef].Primary == allHandTypes[handRef - 1].Primary)
{
if (allHandTypes[handRef].Secondary < allHandTypes[handRef - 1].Secondary)
{
winningHand = myHand;
bestHand = hand;
handRef++;
}
}

You'd still have the problem of coding the second ranking in the first place though I could help with that if you could post the relevant code.
lee croydon11y ago
yes the hands ranking is determined before the if else statement above, which does work quite well until there are two hands that have equal rank. but the more i think about it there is not going to be a simple way of comparing the 2 arrays to determine which of those is infact the best hand when the situation arises :(
Vulpes11y ago
OK, but I think it will boil down to the same approach since you must be using the 7 card array to determine the hand's ranking and description in the first place based on the 'best' 5 cards.
lee croydon11y ago
Hi Vulpes, thank you for the incite.... in regards to your first observation i will not be using myHand to determine this calculation.... i will be hoping to use hand which is an array of type Card used to test the hands to verify the handType and bestHand which is also an array of type Card.. what i am looking to do is test these 2 hands against each other both arrays will hold 7 cards i.e the hole cards and the 5 table cards
Vulpes11y ago
One observation I'd make straightaway is that if myHand, hand etc. are strings which contain descriptions such as 'Pair of Kings', 'Ace high' etc then you're not always going to be able to determine which is the better of otherwise equal ranking hands from the descriptions alone.

This is because if you have the same two pairs, pair or card high, the other cards in the hand will be used to determine which is the better hand. You also have a similar problem with flushes.

So, if two players A and B both have a pair of Aces and a pair of Kings and A's fifth card is a Queen but B's fifth card is a Jack, then A will be the winner.

I think therefore that in the part of your code which determines the ranking of a given hand and it's description, you will need to generate an additional ranking which can be used to distinguish between otherwise equally ranking hands.

You could perhaps use a struct to bind the two rankings together.

As regards the calculation of the second ranking, if we say a deuce has a value of 2, a trey has a value of 3 and so on up to a ten and then a Jack 11, Queen 12, King 13 and Ace 14, you could calculate the ranking as follows:

Straights - the value of the highest card (e.g. AKQJ10 has a ranking of 14).

Flushes (or card high) - multiply the values of all 5 cards together (e.g. AJ972 has a ranking of 14 * 11 * 9 * 7 * 2 = 19404)

Four (or three) of a kind - the value of such card (e.g 3333A has ranking of 3).

Full house - multiply value of 3 of a kind by 14 and add value of pair (e.g. AAAKK has ranking of 14 *14 + 13 = 209).

Two pairs - multiply value of pairs together and add value of fifth card (e.g. AAKK2 has ranking of 14 * 13 + 2 = 184)

Pair - multiply value of pair by 14 * 14 * 14 = 2744 and add the product of the values of the other three cards (e.g.QQ973 has ranking of 2744 *12 + 9 * 7 * 3 = 33117)

Hope these remarks are of some help.