string.insert problem

mreister

I am trying to trim s3 off the end of stringToSplit. It splits into the array ok but when i call string.insert() it simply doesn't add anything to newString. here is the code: string stringToSplit = "s1/s2/s3"; string[] stringArray = stringToSplit.Split('/'); string newString = ""; for(int y = 0;y != stringArray.Length - 1;y++) { newString.Insert(newString.Length,stringArray[y].ToString()); }

6 Replies

Know the answer? Post it — somebody with the same question will find it here.

sacresp23y ago
is string.concat any better?
tsuman_in23y ago
I'm with spoimala. At least use string.Concat.
sacresp23y ago
Concatenating strings is inefficient as string is immutable class, use StringBuilder instead ;)
prasad.narwadkar23y ago
I have a few comments on the original code. 1. Using ToString() on a string instance is no good programming technique. ToString() should be used only on non-string objects. 2. Insert() works only if the string to insert into is having sufficient length to accommodate the new resulting string. Use the code below to exactly do what you desire. string stringToSplit = "s1/s2/s3"; string[] stringArray = stringToSplit.Split('/'); string newString = ""; for(int y = 0,position = 0;y != stringArray.Length - 1;y++) { newString = newString.Insert(position,stringArray[y]); position = stringArray[y].Length; }
Mahesh Chand23y ago
Sounds good ;)
mreister23y ago
solved problem. i used this. for(int y = 0;y != stringArray.Length - 1;y++) { newSubjectString += "/"; newSubjectString += stringArray[y]; }