Solved:Problem writing to a file

Michael Cline

Wow it's been a while since I've been on these forums, a lot has changed. Looks good, :)

I have a rather strange problem, for the life of me I can't figure out what I did wrong, but here goes.

I have an array of map tile information such as mapTile[i,n] really they're just strings containing the sprite sheet, and position of the tile that should be displayed. the strings are relatively small, maybe 7 chars long.

when I create a blank map, i write the first line containing the maps name, height and width, and the event file associated with the map.

then I loop through the tiles writing each on its own line, the problem is it cuts off at the same place each time, I'm not sure if there is a maximum number of lines etc, but I see no problem with my code. and it cuts off in the middle of a string. anyway heres my code:

 public void CreateNewMap(string Filename, int width, int height)
        {
            TextWriter tw = new StreamWriter(Filename + ".dat");
            string firstline = Filename + "#" + width + "#"+ height +"#72" ;//Map Information line
            tw.WriteLine(firstline);
            for(int i = 0; i < height;i++)  //Set Every tile to empty. . . 
            {                
                for (int n = 0; n < width; n++)
                {
                    tw.WriteLine("0;0;0#0");
                }                
            }
        }

Any help would be greatly appreciated.

I've been testing with a 100x100 map size. it cuts off at line 9898 and on that line only the first 4 char's are written.

5 Replies

Know the answer? Post it — somebody with the same question will find it here.

Sam Hobbs15y ago
In .Net we must Flush output files. It seems ridiculous to me that it is not done automatically; other languages and libraries does that automatically. If closing works for you then that is good but my experience is that we must explicitly Flush. Sometimnes I do Flush, then Close then Dispose. I think that Dispose is useful if you need to re-open the file or it you need to release the file for use in other applications. I guess this is caused by garbage collection; garbage collection is intended to make things easier but it ends up making things more complicated for many things.

Also, try using a "using" block for files. It seems like a cumbersome thing to do and I don't like it but it is the C# way to do things. The purpose of a "using" block is to ensure that clean-up is done as needed.
Vijay Yadav15y ago
Hi Micheal,
Your code is running fine.
Check it once again

Thanks
Vijay
Kirtan Patel15y ago
ur Welcome ..
Michael Cline15y ago
So it wrote all of it to the file then? Thats unfortunate, that means theres something wrong with my computer. or another part of my code. . . which will be difficult to find.

Edit:
Well it seems as though it's because I didn't close the stream writer. after adding that it works perfectly, i remove it and the problem comes back. I apparently need to conform to good coding practices more often, thanks for your help.

Kirtan Patel15y ago

there is no problem with ur code its running 1000 times perfectly ...i checked it on my machine

public void CreateNewMap(string Filename, int width, int height)
        {
            int count = 0;
            TextWriter tw = new StreamWriter(Filename + ".dat");
            string firstline = Filename + "#" + width + "#" + height + "#72";
            tw.WriteLine(firstline);
            for (int i = 0; i < height; i++)  . 
            {
                for (int n = 0; n < width; n++)
                {
                    tw.WriteLine("0;0;0#0");
                    count++;
                }
            }
            tw.Close();
            MessageBox.Show(count.ToString());
        }