Parameter is not valid.

saifullah khan

15y22.1k.NET

i have a ppt file which i have converted from ppt to image and then save it in db. it save successfully. then i retrieve it from db but it gives and error:
parameter is not valid
Image imag = Image.FromStream(stream);

here is the code for saving in db:
protected void Button1_Click(object sender, EventArgs e)
      {
            ApplicationClass pptApplication = new ApplicationClass();
            Presentation pptPresentation = pptApplication.Presentations.Open("saifullah.ppt", MsoTriState.msoFalse,
            MsoTriState.msoFalse, MsoTriState.msoFalse);

            var slides = new List();

            for (var i = 1; i <= pptPresentation.Slides.Count; i++)
            {
                  string target = i+".jpeg".ToString();

               pptPresentation.Slides[i].Export(target, "jpg", width, height);

                  string pic = target;



         con.Open();
         cmd = new SqlCommand("insert into images values('"+@pic+"')",con);
         cmd.ExecuteNonQuery();
         con.Close();

            }

            pptPresentation.Close();
}

and here is for retreiving from db.

MemoryStream stream = new MemoryStream();
            try
            {
                  con.Open();
                  cmd = new SqlCommand("select pics from images", con);
                  byte[] image = (byte[])cmd.ExecuteScalar();

                  stream.Write(image, 0, image.Length);

                  Image imag = Image.FromStream(stream);
                  Response.ContentType = "image/JPEG";
                  imag.Save(Response.OutputStream, System.Drawing.Imaging.ImageFormat.Jpeg);
            }
            finally
            {
                  con.Close();
                  stream.Close();
            }

please tell me what i need to correct

19 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes15y ago
Accepted answer
Suthish is right that getting the images into a gridview should really be a new question.

However, I'll just add that you'll need to use a different approach for this as Response.OutputStream can only deal with a single file at a time.

I'd take a look at the second half of the article below which should get you on the right track:

http://www.aspdotnetcodes.com/Insert_Images_Database.aspx
Suthish Nair15y ago
And also you must accept the answer as correct for right thread which related through to your actual question.
Suthish Nair15y ago
That's a new question, then new thread.. plz
saifullah khan15y ago
i want to print them on web page either in a grid view or any other method.
Vulpes15y ago
Well, the ExecuteScalar() method will only return a single image, namely the one in the first row of the database.

To get all the images one by one you'll need to use ExecuteReader() in a while loop.

However, how are you are proposing to save multiple images to the response output stream?
Javeed M Shaikh15y ago
Vulpes,

your 'deja vu' sense is correct and it is coming from here:

http://www.c-sharpcorner.com/Forums/Thread/145822/parameter-is-not-valid.aspx
saifullah khan15y ago
sir now when i retreive images from db to only one image is shown. here is the code i dont understande where to use the loop.
con.Open();
cmd = new SqlCommand("select pics from images", con);
byte[] image = (byte[])cmd.ExecuteScalar(); stream.Write(image, 0, image.Length);
stream.Seek(0, SeekOrigin.Begin);
Image imag = Image.FromStream(stream);
Response.ContentType = "image/JPEG"; imag.Save(Response.OutputStream, System.Drawing.Imaging.ImageFormat.Jpeg);
could you please help me in this point?
Vulpes15y ago
The code I posted earlier should achieve that:

Image image = Image.FromFile(targetPath); // where targetPath is full path to file
MemoryStream ms = new MemoryStream();
image.Save(ms, System.Drawing.Imaging.ImageFormat.Jpeg);
byte[] pic = ms.ToArray();
cmd = new SqlCommand("insert into images values(@picture)",con);
cmd.Parameters.Add("@picture", pic);
cmd.ExecuteNonQuery();

What this is doing is loading the file into memory, converting it to a byte array and then saving the byte array to the database.

In your other class, you then retrieve this byte array from the database and convert it back to an image.
saifullah khan15y ago
sir actually it must be saved in db. but by default it is being saved on desktop. targetPath = server.MapPath("~/NewFolder1/"); targetPath += "\\{0}"; this is the way to assign path but i want to convert it to db path
Vulpes15y ago
The Image.FromFile method needs the full path of the file to load - otherwise it assumes it will be in the current directory.

You therefore need to replace 'target' with the full path to the file.

Another approach would be not to save the image itself to the database but just the path to it (as a string), but I'd see if you can get the present approach to work first.
saifullah khan15y ago
yup i found files are being written on desktop so what i need to do so that they directly save in db?
saifullah khan15y ago
i have change the file formate from jpg to png, but it still gives the same error
Vulpes15y ago
I don't understand the file not found exception as we're using exactly the same name as was used in the Export method.

However, the error message says '1.jpg' and not '1.jpeg'?

Can you try and figure out where these files are being written. I expected it to be the current directory but perhaps it's some other default location
saifullah khan15y ago
parameter is not valid Image imag = Image.FromStream(stream);
saifullah khan15y ago
file not found:1.jpg Image image = Image.FromFile(target);
Vulpes15y ago
I'm getting a sense of 'deja vu' here :)

The problem this time is that you're writing a string to the database rather than the image itself.

I imagine that the Export() method will write to a disk file so I'd suggest you try:

protected void Button1_Click(object sender, EventArgs e)
{
ApplicationClass pptApplication = new ApplicationClass();
Presentation pptPresentation = pptApplication.Presentations.Open("saifullah.ppt", MsoTriState.msoFalse, MsoTriState.msoFalse, MsoTriState.msoFalse);

con.Open();

for (var i = 1; i <= pptPresentation.Slides.Count; i++)
{
string target = i.ToString() +".jpeg";
pptPresentation.Slides[i].Export(target, "jpg", width, height);
Image image = Image.FromFile(target);
MemoryStream ms = new MemoryStream();
image.Save(ms, System.Drawing.Imaging.ImageFormat.Jpeg);
byte[] pic = ms.ToArray();
cmd = new SqlCommand("insert into images values(@picture)",con);
cmd.Parameters.Add("@picture", pic);
cmd.ExecuteNonQuery();
}

con.Close();
pptPresentation.Close();
}

The code for retrieving from the database should be exactly the same as what you finished up with in your previous thread.

Prabhu Raja15y ago

Try this one.

MemoryStream stream = new MemoryStream();
            try
            {
                  con.Open();
                  cmd = new SqlCommand("select pics from images", con);
                  byte[] image = (byte[])cmd.ExecuteScalar();

                  stream.Write(image, 0, image.Length);
          stream.Seek(0, SeekOrigin.Begin);
          Image imag = Image.FromStream(stream);
                  Response.ContentType = "image/JPEG";
                  imag.Save(Response.OutputStream, System.Drawing.Imaging.ImageFormat.Jpeg);
            }
            finally
            {
                  con.Close();
                  stream.Close();
            }

saifullah khan15y ago
i have used ur given code but it gives the same error
Prabhu Raja15y ago
Hi,

Check whether the stream is null or not Before using. Use Breakpoints or if condition to do that.

if(stream != null)
{
Image imag = Image.FromStream(stream);

}
else
{
MessageBox.Show("Stream is null");
}