Iterating through an array using ForEach

Question

Hello. Brilliant forum by the way. Why doesn't this work please? public void InitializePack() { Card [] pack= new Card[52]; for ( int i = 0; i for ( int j = 1; j pack[(i*13)+j-1] = new Card((Suits)i, (Values)j); } } foreach (Card c in pack) Console.WriteLine(c.Name); } c is null at first iteration. I have only seen examples of foreach iterating through arrays whose elements are defined at declaration using {}. Is this the issue? I've not included the rest of the code as I thought you'd see this one straight away. Thanks very much!

Dharmraj Thakur · Answer

Please show what is the signature of Card , Suits and Values class?

Dharmraj Thakur · Answer

I implement your code... its working fine, Where is the issue? class Card { public Card(Suits suit, Values value) // This constructor has integer values sent to it { this .Suit = suit; this .Value = value; } public Suits Suit { get ; set ; } public Values Value { get ; set ; } public string Name { get { //return Value.ToString() + " of " + Suit.ToString(); // The integer values can be converted to their reference names return (Values)Value + " of " + (Suits)Suit; // Here's another way of doing it - Casting to their type, not to string } } } enum Suits { Hearts, // 0 'Hearts' is of type Suits Clubs, // 1 Diamonds, // 2 Spades // 3 } enum Values { Ace = 1, // 'Ace' is of type Values Two = 2, Three = 3, Four = 4, Five = 5, Six = 6, Seven = 7, Eight = 8, Nine = 9, Ten = 10, Jack = 11, Queen = 12, King = 13 } class Program { static void Main( string [] args) { InitializePack(); Console.ReadKey(); } public static void InitializePack() { Card[] pack = new Card[52]; for ( int i = 0; i { for ( int j = 1; j { pack[(i * 13) + j - 1] = new Card((Suits)i, (Values)j); } } foreach (Card c in pack) Console.WriteLine(c.Name); } }

Nigel Foster · Answer

class Card { public Card(Suits suit, Values value) // This constructor has integer values sent to it { this .Suit = suit; this .Value = value; } public Suits Suit { get ; set ; } public Values Value { get ; set ; } public string Name { get { //return Value.ToString() + " of " + Suit.ToString(); // The integer values can be converted to their reference names return (Values)Value + " of " + (Suits)Suit; // Here's another way of doing it - Casting to their type, not to string } } } enum Suits { Hearts, // 0 'Hearts' is of type Suits Clubs, // 1 Diamonds, // 2 Spades // 3 } enum Values { Ace=1, // 'Ace' is of type Values Two=2, Three=3, Four=4, Five=5, Six=6, Seven=7, Eight=8, Nine=9, Ten=10, Jack=11, Queen=12, King=13 } Thanks for your interest in the post guys! pack.Length is 52, pack[0].Name="Ace of Hearts" and pack[51].Name="King of Spades" so all is good up to the foreach block.

Mukesh Nayak · Answer

Hi Nigel I think the issue is there with the iteration of “i”. Probably the following line pack[(i*13)+j-1] = new Card((Suits)i, (Values)j); in new Card((Suits)i, (Values)j) For the first iteration i = 0 and j = 1 So somehow new Card((Suits)0, (Values)1) is null. Regards, Mukesh Nayak

Arunprasath Gajapathi · Answer

it may exceed the array index after i=4

Iterating through an array using ForEach

Answers (5)