how to solve date string not in correct format

protected void btnUpdate_Click1(object sender, EventArgs e)
{
//TextBox txtISIN = (TextBox)grdLabEntry.Rows[0].FindControl("txtISINNumber");
TextBox txtGrade = (TextBox)grdLabEntry.Rows[0].FindControl("txtGrade");
TextBox txtValidity = (TextBox)grdLabEntry.Rows[0].FindControl("txtValidity");
TextBox txtFED = (TextBox)grdLabEntry.Rows[0].FindControl("txtFED");
//DMatEntry obj = new DMatEntry();
SpotEntry obj = new SpotEntry();
obj.SpotEntryId = RId;
//obj.ISINNumber = txtISIN.Text;
obj.Grade = txtGrade.Text;
obj.Validity = Convert.ToDateTime(txtValidity.Text);
obj.FEd = Convert.ToDateTime(txtFED.Text);
int result = SpotEntry.UpdateLabEntry(obj);
if (result > 0)
{
grdLabEntry.EditIndex = -1;
obj.SpotEntryId = RId;
DataTable dt = SpotEntry.GetAllDmatRecordsById(obj);
if (dt.Rows.Count > 0)
{
showmsg("Dmat Lab Entry Updated Successfully.");
grdLabEntry.DataSource = dt;
grdLabEntry.DataBind();
}
}

On second thoughts, is there not any date-time picker control you can use?

Much better from user perspective, less error prone and can possibly give you date value in yyyy-MM-dd format which would be less likely to fail in serveral different environments.

Methods like ToDateTime() or ToString() of DateTime Structure are dependent on the regional settings of the machine and should never be used, because they are likely to go wrong if regional settings of your development machine and that of deployment server is different.

The reson you are getting this error is for the same above reason. There is diff between user input format and machine's regional settings format.

It is always a good practise to stick to yyyy-MM-dd date format while communicating with computer systems (such as C#, Database, JSON, XML, csv, etc.) and format them only in UI layer as per user's expectation.

// TextBox txtISIN = (TextBox)grdLabEntry.Rows[0].FindControl("txtISINNumber");
TextBox txtGrade = (TextBox)grdLabEntry.Rows[0].FindControl("txtGrade");
TextBox txtValidity = (TextBox)grdLabEntry.Rows[0].FindControl("txtValidity");
TextBox txtFED = (TextBox)grdLabEntry.Rows[0].FindControl("txtFED");
//string fed, validity;
//validity = Convert.ToDateTime(txtValidity.Text).ToString("MM/dd/yyyy");
//fed= Convert.ToDateTime(txtFED.Text).ToString("MM/dd/yyyy");
////string[] formats = { "dd/mm/yyyy" };
////var d = DateTime.ParseExact(date.ToString(), formats, new System.Globalization.CultureInfo("en-US"), System.Globalization.DateTimeStyles.None);
DateTime validityDate = DateTime.ParseExact(txtValidity.Text, "dd/MM/yyyy", System.Globalization.CultureInfo.InvariantCulture);
DateTime fed = DateTime.ParseExact(txtFED.Text, "dd/MM/yyyy", System.Globalization.CultureInfo.InvariantCulture);
SpotEntry obj = new SpotEntry();
obj.SpotEntryId = RId;
// obj.ISINNumber = txtISIN.Text;
obj.Grade = txtGrade.Text;
obj.Validity = Convert.ToDateTime(validityDate);
obj.FEd = Convert.ToDateTime(fed);
int result = SpotEntry.UpdateLabEntry(obj);
if (result > 0)
{
grdLabEntry.EditIndex = -1;
obj.SpotEntryId = RId;
DataTable dt = SpotEntry.GetAllDmatRecordsById(obj);
if (dt.Rows.Count > 0)
{
grdLabEntry.DataSource = dt;
grdLabEntry.DataBind();
}

}

it not working

DateTime validityDate = DateTime.ParseExact(txtValidity.Text, "dd/MM/yyyy", CultureInfo.InvariantCulture);

in this line getting error on 'CultureInfo'

Hi, please try this.

This is more accurate

DateTime validityDate = DateTime.ParseExact(txtValidity.Text, "dd/MM/yyyy", CultureInfo.InvariantCulture);

hello

where i place this code in my code when i place this

obj.Validity =Convert.ToDateTime(txtValidity.Text).ToString("dd/MM/yyyy");

i am getting error

it not work error is not valid date time

This is the another solution.

DateTime validityDate = DateTime.ParseExact(txtValidity.Text, "dd/MM/yyyy", CultureInfo.InvariantCulture);

Please try this.

Convert.ToDateTime(txtValidity.Text).ToString("dd/MM/yyyy")

Please mark as answer if it helps.

8 Replies

Know the answer? Post it — somebody with the same question will find it here.

Nitin Sontakke8y ago
On second thoughts, is there not any date-time picker control you can use?

Much better from user perspective, less error prone and can possibly give you date value in yyyy-MM-dd format which would be less likely to fail in serveral different environments.
Nitin Sontakke8y ago
Methods like ToDateTime() or ToString() of DateTime Structure are dependent on the regional settings of the machine and should never be used, because they are likely to go wrong if regional settings of your development machine and that of deployment server is different.

The reson you are getting this error is for the same above reason. There is diff between user input format and machine's regional settings format.

It is always a good practise to stick to yyyy-MM-dd date format while communicating with computer systems (such as C#, Database, JSON, XML, csv, etc.) and format them only in UI layer as per user's expectation.
Deekshaa Singh Chauhan8y ago
1. // TextBox txtISIN = (TextBox)grdLabEntry.Rows[0].FindControl("txtISINNumber");
2. TextBox txtGrade = (TextBox)grdLabEntry.Rows[0].FindControl("txtGrade");
3. TextBox txtValidity = (TextBox)grdLabEntry.Rows[0].FindControl("txtValidity");
4. TextBox txtFED = (TextBox)grdLabEntry.Rows[0].FindControl("txtFED");
7. //string fed, validity;
8. //validity = Convert.ToDateTime(txtValidity.Text).ToString("MM/dd/yyyy");
9. //fed= Convert.ToDateTime(txtFED.Text).ToString("MM/dd/yyyy");
11. ////string[] formats = { "dd/mm/yyyy" };
12. ////var d = DateTime.ParseExact(date.ToString(), formats, new System.Globalization.CultureInfo("en-US"), System.Globalization.DateTimeStyles.None);
14. DateTime validityDate = DateTime.ParseExact(txtValidity.Text, "dd/MM/yyyy", System.Globalization.CultureInfo.InvariantCulture);
15. DateTime fed = DateTime.ParseExact(txtFED.Text, "dd/MM/yyyy", System.Globalization.CultureInfo.InvariantCulture);
17. SpotEntry obj = new SpotEntry();
18. obj.SpotEntryId = RId;
19. // obj.ISINNumber = txtISIN.Text;
20. obj.Grade = txtGrade.Text;
21. obj.Validity = Convert.ToDateTime(validityDate);
22. obj.FEd = Convert.ToDateTime(fed);
26. int result = SpotEntry.UpdateLabEntry(obj);
27. if (result > 0)
28. {
29. grdLabEntry.EditIndex = -1;
31. obj.SpotEntryId = RId;
32. DataTable dt = SpotEntry.GetAllDmatRecordsById(obj);
33. if (dt.Rows.Count > 0)
34. {
35. grdLabEntry.DataSource = dt;
36. grdLabEntry.DataBind();
37. }
}
it not working