How to improve the functionality of this code in the face of new requi

Fabiola Martinez

Hi, I'm working with asp.net mvc c#. I have a form the allows users to register absences.

This form has three fields, a DropDownList with the list of reasons for absence (Illness, Study day, Other reason), date (the system takes the date) and description. But depending on the selected item it is validated for example. If the user selects the Illness item, it shows another DropDownList with the items (Abdominal Pain, Fever) and if it is by Study Day, they are allowed to select a date but with the restriction of notifying the absence of it 5 days in advance. If the user selects Other Reasons, another DropDownList is shown with the following items (Free Day, Moving) with the restrictions, for Free Day it should only be allowed between the 1st to the 5th of each month, after those days it should no longer allow record an absence. For Moving three days in advance, the absence must be registered.

This is my code

public bool CreateAbsence (Absence absence)
{
/*Id Reason Study Day = 2*/
if (absence.ReasonId == 2)
{
int _dayAb = dayAbsence.Day;
int _dayCu = dateCurrent.Day;
if ((_dayAb - _dayCu) <= 5) //You must register 5 days in advance.
{
//It is not allowed to create absence.
return;
}
}
/*Id Reason Free Day = 5*/
else if (absence.SubReason == 5)
{
int dayAb = dayAbsence.Day;
if (dayAb >= 5) //It is only allowed until the 5th of each month.
{
//It is not allowed to create absence.
return;
}
}
/*Id Moving = 8*/
else if (absence.SuBReason == 8)
{
int _dayAb = dayAbsence.Day;
int _dayCu = dateCurrent.Day;
if ((_dayAb - _dayCu) <= 2) //You must register 3 days in advance.
{
//It is not allowed to create absence.
return;
}
}
//it is allowed to create the absence
}

I want to know how I can improve this code when new requirements appear. What do you recommend me? I'm looking at a bit of SOLID principles but still don't figure out how to fix this. Sorry if I extended myself too long. Thanks,

3 Replies

Know the answer? Post it — somebody with the same question will find it here.

Mahesh Vishwakarma5y ago
You can use database for this type of requirement
create Reason & SubReason table

Reason Table

ID number identity
ReasonID number primary key
status bit
createddate date
createdby varchar
updateddate date
updatedby varchar

SubReason Table

ID number identity
SubReasonID number
ReasonID number foreigne key
Message varchar
Absenceday number
createddate date
createdby varchar
updateddate date
updatedby varchar

Select R2.Message
From Reason R1
INNER JOIN SubReason R2 ON R2.ReasonID = R1.ReasonID
Where R1.status = 1 AND R1.ReasonID = 2 AND R2.SubReasonID = 2 AND TO_DATE(dayAbsence, 'DD-MM-YY') - TO_DATE(sysdate,'DD-MM-YY') <= R2.Absenceday

In class use below condition
Datatable dt = new Datatable();
dt = //call sp with input parameter
if(dt.Rows.count > 0)
{
return dt.Rows[0]["Message"];
}
0
Fabiola Martinez5y ago
Hi

Thank for your ansewer.

But, how to avoid IF / Else nesting, if I need to add more Reason and SubReason.

This is my class.
public class Absence()
{
      public int Id {get; set;}
      public int ReasonId {get; set;}
      public int SubReasonId {get; set;}
      public DateTime Date {get; set;}
      public DateTime SelectedDate {get; set;}
      public string Description {get; set}
}

public class Reason()
{
      public int Id {get; set;}
      public string Description {get; set}

      public ICollection SubReasons {get; set;}
}

public class SubReason()
{
      public int Id {get; set;}
      public string Description {get; set}
}
0
Rijwan Ansari5y ago
Hi

Modified version
public bool CreateAbsence (Absence absence)
{
    /*Id Reason Study Day = 2*/
     if ((absence.ReasonId == 2) && ((dayAbsence.Day - dateCurrent.Day) <= 5)) //You must register 5 days in advance.
            return;   //It is not allowed to create absence.
    else if ((absence.SubReason == 5) && (dayAbsence.Day >= 5)) //*Id Reason Free Day = 5*/ and It is only allowed until the 5th of each month.
            return;     //It is not allowed to create absence.
    else if ((absence.SuBReason == 8) && (dayAbsence.Day - dateCurrent.Day) <= 2))    / /*Id Moving = 8*/  //You must register 3 days in advance.
            return;    //It is not allowed to create absence.

    //it is allowed to create the absence
}
You can do it easily way without writing much code.
+2