how to decrease time of long running method in c#(windows form)

R.D Ip

5y1.4k.NET

I am trying to decrease a form load time

Main.cs

private void UTMaster_ToolClick(object sender, ToolClickEventArgs e) //when I click on tag then this will call
{
OrganisationMethod(sender,e);
}

private void OrganisationMethod(object sender, ToolClickEventArgs e)
{
Form frms = (Form)Activator.CreateInstance(Type.GetType(strtagname));
Type ObjType = frms.GetType();
MethodInfo method = ObjType.GetMethod("ShowOrganisationForm"); //ShowOrganisationForm is a form
ParameterInfo[] Arrayparams = method.GetParameters();
if (Arrayparams.Length == 0)
{
method.Invoke(frms, new object[0]);
}
else
{
//frms.Load += new (method);
object[] paramsArray;
paramsArray = new object[] { e.Tool.propertytag.Tag.ToString() };
method.Invoke(frms, paramsArray);
}
}

organiseform.cs

public void ShowOrganisationForm()
{
DataSetControl(); //this method take too much time to load
this.Show();
}

private void DataSetControl()
{
//multiple combox fill code here
}

I am working with windows form

I am trying to decrease the form load time but not work please help

9 Replies

Know the answer? Post it — somebody with the same question will find it here.

R.D Ip5y ago
hello amit ji and rizwan ji and kiran ji can you help more

below is my code please can you tell me which place I am doing wrong
public void ShowOrganisationForm()
{
      this.Show();         //here my form open
      Combofill_Data();   //here fill the combobox using store procedure

}

public async Task Combofill_Data()
{
    _shopingmast.fillcombo(param1,param2,param3);
}

public DataSet fillcombo(string param1, string param2, string param3)
{
    Ope.Clear();
    Ope.AddParams("tran_code", param1);
    Ope.AddParams("shop_code", param2);
    Ope.AddParams("aun_code", param3);
    Ope.FillDataSet(Ope.EnumServer.ShopCity, DS, tblName, SProc.usp_fillTranCombo, Ope.GetParams());    //this store procedure take a long time (6 second)//I am trying to reduce 3 second
    return DS;
}
currently what happen open a ShowOrganisationForm form then after hang the ShowOrganisationForm form for 10 second that is main issue

please please help
Rijwan Ansari5y ago
Try Async and wait.
public void ShowOrganisationForm()
{
      await DataSetControlAsync();
      this.Show();
}
public async Task DataSetControlAsync()
{
     await Task.Factory.StartNew(() => DataSetControl());  //this function should be async
}
R.D Ip5y ago
hello amit ji

filling comboboxes method take a load time (5 second) and I want to reduce 3 second
public async Task Sp_Data()

{

await Task.Factory.StartNew(() => DataSetControl());

}



public void  DataSetControl()

{

  //filling combobox data code

}

I am using infragistic ultragrid can u tell me which event load the sp_Data() method

I want to put sp_Data method in ultragrid event but which event I don't know
combobox inside the ultragrid and combobox fill data in ultragrid so i want to call ultra grid combobox event but which event I don't know?
Amit Gupta5y ago
Ah! We are having the same name of method and in task.factory(..) i.e DataSetControl. It is recursive in nature. Use yohr appropriate methodname accordingly. Can you share the code what you are calling inside it (filling comboboxes etc) it needs to be optimised
R.D Ip5y ago
I am trying the below method but it take too much load time
public void ShowOrganisationForm()
{
      this.Show();
      DataSetControl();

}
public void DataSetControl()
{
     Task.Factory.StartNew(() => DataSetControl()).Wait();
}
still I am not able to find out the solution?
can you help more
Kiran Mohanty5y ago
Hi,
You can try Task parallel library to achieve async call.
Amit Gupta5y ago
Task.Factory.StartNew is an older function that doesn't use the best of async and await keywords.

Task.Run(..) approaches better use of these keywords and to use this, you have to upgrade your .NET Framework with minimum supported is 4.5 but I highly recommend you to always use the latest stable version in the matket which has various improvment and fixes.

If you still want to stick with the current one then, try like below
public void ShowOrganisationForm()
{
      this.Show();
      DataSetControl();

}
public void DataSetControl()
{
     Task.Factory.StartNew(() => DataSetControl()).Wait();
}
NOTE: As you are accessing controls from a seperate thread, that are created on the main thread, you should use the below line in the class contructor
CheckforillegalThreadCalls = false

Good Luck
R.D Ip5y ago
hi Amit,

trying this async method but give an error:

'Task' does not contain a definition for 'GetAwaiter' and no accessible extension method 'GetAwaiter' accepting a first argument of type 'Task' could be found (are you missing a using directive or an assembly reference?)

organiseform.cs
public void ShowOrganisationForm()

{

DataSetControlAsync();

      this.Show();

}
public async Task DataSetControlAsync()

{

     await Task.Factory.StartNew(() => DataSetControl()); //here give an error

}

my project version framework is: 4.0.0.0
can you help more
Amit Gupta5y ago
You should call the show method at first and rest fill the combobox asynchronously or on a seperate thread