How to allow multithreading to generate 100000 datamatrix 2d

ahmed salah

9y1.1kC#

I generating 2d matrix barcode using c# then create image file

but when i make generating to 100000 files it make very slow and take too much time

so that i need to make multithreading but i dont know how

my code as following

string root = @"D:\" +textBox4.Text;
if (!Directory.Exists(root))
{
Directory.CreateDirectory(root);
}
matrixClass CLS = new matrixClass();
DataTable dt = CLS.ShowalldataSerial(textBox4.Text);
for (int i = 0; i <= Convert.ToInt32(textBox1.Text); i++)
{
Serial = SRL.Rnd().ToString();
txt = "UserID" + dt.Rows[0][0] + "FirmName" + dt.Rows[0][1] + "OrderNo" + dt.Rows[0][2] + "BtachNo" + dt.Rows[0][3] + "Quantity" + dt.Rows[0][4] + "ProductName" + dt.Rows[0][5] + "SerialNo" + Serial;
dm.DM(txt, Color.FromName(comboBox1.SelectedItem.ToString()), Color.White).Save(root + "\\" + Serial + ".emf", System.Drawing.Imaging.ImageFormat.Emf);
}
MessageBox.Show("Records generated success");

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Mukil Vendhan9y ago
For one you could take this multi-threaded. That would do wonders.

Next you could employer better basic coding principals.

Using a textbox as if it were a variable is bad enough. But then you are accessing it for its value and converting _that_ to a number... 100,000 times: Once for each iteration of the loop.
for (int i = 0; i <= Convert.ToInt32(textBox1.Text); i++)
Then you do that same sort of bad practice within the loop here
Color.FromName(comboBox1.SelectedItem.ToString())
And...
Ever iteration of the loop is held up by the hard drive because of the nested save. Meaning the next barcode can't be generated until the last one is done saving. That's a huge bottleneck.
.Save(root + "\\" + Serial + ".emf"
It couldn't be much slower if you _tried_ to slow it down. I'm guess either a first year student or Mumbai outsourcer wrote it.
0
ahmed salah9y ago
Thank you for reply
I using multi threading as following in code
lass1 CLS = new Class1();
    DataTable dt = CLS.ShowalldataSerial(textBox4.Text);
     string baseText = "UserID" + dt.Rows[0][0] + "FirmName" + dt.Rows[0][1] + "OrderNo" + dt.Rows[0][2] + "BtachNo" + dt.Rows[0][3] + "Quantity" + dt.Rows[0][4] + "ProductName" + dt.Rows[0][5] + "SerialNo";
        Color foregroundColor = Color.FromName(comboBox1.SelectedItem.ToString());
        int serialsToGenerate = Convert.ToInt32(textBox1.Text);
        Parallel.For(0, serialsToGenerate, index=>
        {
            string Serial = SRL.Rnd().ToString();
            string txt = baseText + Serial;
            // WARNING HERE
            DM_Encoder dm = new DM_Encoder();
            dm.DM(txt, foregroundColor, Color.White).Save(root + "\\" + Serial + ".emf", System.Drawing.Imaging.ImageFormat.Emf);
        });
But until now it take more time to save generating files if i generating big quantity
as 200000
so that are there are any solutions to minimize time that take from 20 minutes to 8 minutes per 200000 files saved as barcode 2d matrix
0
ahmed salah9y ago
Thank you for reply
I using multi threading as following in code
lass1 CLS = new Class1();
    DataTable dt = CLS.ShowalldataSerial(textBox4.Text);
     string baseText = "UserID" + dt.Rows[0][0] + "FirmName" + dt.Rows[0][1] + "OrderNo" + dt.Rows[0][2] + "BtachNo" + dt.Rows[0][3] + "Quantity" + dt.Rows[0][4] + "ProductName" + dt.Rows[0][5] + "SerialNo";
        Color foregroundColor = Color.FromName(comboBox1.SelectedItem.ToString());
        int serialsToGenerate = Convert.ToInt32(textBox1.Text);
        Parallel.For(0, serialsToGenerate, index=>
        {
            string Serial = SRL.Rnd().ToString();
            string txt = baseText + Serial;
            // WARNING HERE
            DM_Encoder dm = new DM_Encoder();
            dm.DM(txt, foregroundColor, Color.White).Save(root + "\\" + Serial + ".emf", System.Drawing.Imaging.ImageFormat.Emf);
        });
But until now it take more time to save generating files if i generating big quantity
as 200000
so that are there are any solutions to minimize time that take from 20 minutes to 8 minutes per 200000 files saved as barcode 2d matrix
0
Dharmraj Thakur9y ago
Refer this.....

https://www.codeproject.com/Articles/1083/Multithreaded-Programming-Using-C
0