Efficiency of Loop Statements

jc mandapat

Can anyone help me with this problem.Let's sat I want to loop 10 employees using the foreach statement.Under the foreach i have 3 functions that computes their wages,tax and deductions. My question is this.which is more efficient? 1. for every 1 employee, I compute their wages, tax and deductions Ex. Foreach (X in dsEmployees) { Compute Wages(); Compute Taxes(); Compute Deductions(); } 2. I compute all the wages for all employees, all taxes for all employees and all deductions for all employees Ex. Foreach (X in dsEmployees) { Compute Wages(); } Foreach (X in dsEmployees) { Compute Taxes(); } Foreach (X in dsEmployees) { Compute Deductions(); } can anyone help? thanks!

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Bhakeeswaran Thulasingam20y ago
'foreach' loops may be best in case of usage or readability, but not for performance coz' 'foreach' loop works using enumerator. So they can be used only when no. of objects iterated are less or the application is a simple desktop app.
Manoj Bist20y ago
when ever possible use foreach loop, its the best one to iterate through collection
also try to minimize the number of loops
jc mandapat20y ago
"...because, the 'foreach' in turn has the internal implementation of 'for' loop, which really gives u a performance" -- i don't quite get it..please explain, thanks!
Bhakeeswaran Thulasingam20y ago
Hi,
The former method you specified loops through the Particular collection once, where as the latter loops thrice. Why should we iterate the collection thrice whereas we can do the same by iterating only once. This itself specifies the efficient and wise use of loops. So perform all those two operations in one loop itself. And i will also recommend you to use 'for' loops instead of 'foreach' because, the 'foreach' in turn has the internal implementation of 'for' loop, which really gives u a performance.