asp.net core foreach and if not working properly

Marius Vasile

I have the below procedure

var userId = User.FindFirstValue(ClaimTypes.NameIdentifier);
var orgid = await _context.UsersData.Where(s => s.Id == userId).Select(s => s.OrgID).FirstOrDefaultAsync();
var roles = await (from a in _context.UsersData.Where(a => a.Id == userId)
join b in _context.CompanyDatas on a.OrgID equals b.OrgID into TempData1
from c in TempData1
join d in _context.AppIdentityRoles on a.Id equals d.UserId into TempData2
from e in TempData2
join f in _context.UsersRole on e.RoleId equals f.Id into TempData3
from g in TempData3
select new
{
RoleName = g.Name
}).ToListAsync();
string myS = "WOCraftTL";
var status = await _context.WOMains.Where(s => s.WOMainID == womainid).Select(s => s.WOStatus).SingleOrDefaultAsync();
foreach (var a in roles)
{
if (a.RoleName.Contains(myS) && status == "In Progress")
{
return RedirectToPage("/WO/WOReport", new { womainid = womainid });
}
else
{
var womainidP = await _context.WOMains.Where(s => s.WONumber == won && s.WONumberS == 0).Select(s => s.WOMainID).FirstOrDefaultAsync();
return RedirectToPage("/WO/WOForm", new { womainid = womainidP, woS = womainid, status = WOStatusT });
}
}

the user can have multiple roles, however, WOCraftTL is assigned, I verified that and the status for one specific item is "In Progress" but when I run the program the if doesn't work, always else is activated. What am I doing wrong?

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Sachin Singh5y ago
Accepted answer
Remove space in both the places that is in code and database in the status field , convert "In Progress" to "InProgress", also normalize string using ToLower and test.
if (a.RoleName.ToLower().Contains(myS.ToLower()) && status == "InProgress")
Also , you don't need a foreach so remove the foreach block.
Marius Vasile5y ago
Thank you Kiran, it was a matter of using foreach wrongly and it was explained by Sachin privately. See below the updated code which does what expected
var userId = User.FindFirstValue(ClaimTypes.NameIdentifier);
            var orgid = await _context.UsersData.Where(s => s.Id == userId).Select(s => s.OrgID).FirstOrDefaultAsync();

            var roles = await (from a in _context.UsersData.Where(a => a.Id == userId)
                                   join b in _context.CompanyDatas on a.OrgID equals b.OrgID into TempData1
                                   from c in TempData1
                                   join d in _context.AppIdentityRoles on a.Id equals d.UserId into TempData2
                                   from e in TempData2
                                   join f in _context.UsersRole on e.RoleId equals f.Id into TempData3
                                   from g in TempData3

                                   select new
                                   {
                                       g.Name
                                   }).ToListAsync();



            string myS = "WOCraftTL";
            var status = await _context.WOMains.Where(s => s.WOMainID == womainid).Select(s => s.WOStatus).SingleOrDefaultAsync();

            if (roles.Any(x=>x.Name.Equals(myS)) && status == "InProgress")
            {
                return RedirectToPage("/WO/WOReport", new { womainid = womainid });
            }
            else
            {
                var womainidP = await _context.WOMains.Where(s => s.WONumber == won && s.WONumberS == 0).Select(s => s.WOMainID).FirstOrDefaultAsync();
                return RedirectToPage("/WO/WOForm", new { womainid = womainidP, woS = womainid, status = WOStatusT });
            }
Kiran Mohanty5y ago
Probably below line is not returning you "In Progress".
var status = await _context.WOMains.Where(s => s.WOMainID == womainid).Select(s => s.WOStatus).SingleOrDefaultAsync();
Try using below code if it helps.
var status = await _context.WOMains.Where(s => s.WOMainID == womainid).SingleOrDefaultAsync()?.WOStatus;
Marius Vasile5y ago
Unfortunately still not having the results expected