are transaction implemented success on this function or not

I work on csharp function I make enhance to function by add transaction but i dont know

transaction implemented success or it have some thing wrong :

I need answer acording to logic :

public static DataTable ExecuteDataTablesp(string sql, SqlConnection dbConnection, DbParameter[] @params = null, CommandType cmdType = CommandType.StoredProcedure)
{
SqlCommand cmd1 = null;
SqlDataAdapter DA1 = null;
if (dbConnection == null)
{
if (WithTransaction)
dbConnection = (SqlConnection)BeginTransaction();
else
dbConnection = (SqlConnection)InitializeConnection();
}
switch (Provider)
{
case Providers.SQLServer:
cmd1 = new SqlCommand("", dbConnection as SqlConnection);
DA1 = new SqlDataAdapter("", dbConnection as SqlConnection);
if (WithTransaction && _transaction.Connection != null && _transaction.Connection.State == ConnectionState.Open)
{
cmd1.Transaction = (SqlTransaction)_transaction;
cmd1.Connection = (SqlConnection)_transaction.Connection;
}
break;
default:
break;
}
if (sql == "") return new DataTable();
DataSet ds = new DataSet();
try
{
lock (synObj)
{
sql = AnalyizeBooleanFields(sql);
cmd1.CommandText = sql;
cmd1.CommandType = cmdType;
cmd1.Parameters.Clear();
if (@params != null && @params.Length > 0)
{
cmd1.Parameters.AddRange(@params);
}
if (WithTransaction && _transaction.Connection != null && _transaction.Connection.State == ConnectionState.Open)
{
cmd1.Transaction = (SqlTransaction)_transaction;
cmd1.Connection = (SqlConnection)_transaction.Connection;
}
else
{
if (string.IsNullOrEmpty(dbConnection.ConnectionString))
dbConnection.ConnectionString = CreateConnectionString(CurrentDataBase);
if (dbConnection.State != ConnectionState.Open)
dbConnection.Open();
}
// if (WithTransaction) cmd1.Transaction = _transaction;
cmd1.CommandTimeout = 0;
DA1.SelectCommand = cmd1;
DA1.Fill(ds);
if (!WithTransaction && dbConnection.State == ConnectionState.Open)
dbConnection.Close();
}
if (WithTransaction)
{
_transaction.Commit();
}
}
catch
{
_transaction.Rollback();
}
if (WithTransaction && _transaction.Connection.State == ConnectionState.Open)
{
dbConnection.Close();
}
return ds.Tables[0];
}

3 Replies

Know the answer? Post it — somebody with the same question will find it here.

Salman Beg6y ago
Ok. So is _transaction.Commit(); function is executing?
ahmed elbarbary6y ago
with transaction is flag for function when use transaction i assign it to true
Salman Beg6y ago
Hey Are you getting any exception? If _transaction.Commit(); successfully executed means transaction successful otherwise if it is executing _transaction.Rollback() means transaction failed. I don't know what is that WithTransaction. Check this link for example, https://www.c-sharpcorner.com/article/transaction-in-net/